carloea2 opened a new pull request, #8202:
URL: https://github.com/apache/texera/pull/8202

   ### What changes were proposed in this PR?
   
   Exclude control channels when deciding whether all data channels on an input 
port have received a port alignment marker.
   
   The same correction and regression coverage are applied to the Scala and 
Python execution paths.
   
   ### Any related issues, documentation, discussions?
   
   Closes #8201
   
   ### How was this PR tested?
   
   Regression tests were added before the source change. They failed because 
the control channel remained in the required port set, then passed after the 
fix.
   
   ```text
   python -c "import sys,pytest; 
sys.path[:0]=[r'<worktree>\amber\src\main\python',r'<main-checkout>\amber\src\main\python'];
 raise 
SystemExit(pytest.main([r'amber/src/test/python/core/architecture/managers/test_embedded_control_message_manager.py',r'amber/src/test/python/core/architecture/packaging/test_input_manager.py','-q','-p','no:cacheprovider']))"
   29 passed
   
   sbt "WorkflowExecutionService / Test / testOnly 
org.apache.texera.amber.engine.architecture.worker.EmbeddedControlMessageManagerSpec"
   6 passed
   
   ruff check amber/src/main/python amber/src/test/python
   All checks passed
   
   ruff format --check amber/src/main/python amber/src/test/python
   213 files already formatted
   
   sbt scalafmtCheckAll
   success
   ```
   
   The Scala spec was executed with process-local source filters and ignored 
compiled outputs from a recent upstream-based worktree because the normal 
fresh-worktree build is currently blocked by unrelated JOOQ warehouse class 
generation. No generated output is included in this PR.
   
   A direct local runtime probe with one data and one control channel on one 
port returned:
   
   ```text
   data_channels= 1
   port_channels= 2
   data_marker_aligned= True
   alignment_state_retained= False
   ```
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Codex


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to