carloea2 opened a new pull request, #8269:
URL: https://github.com/apache/texera/pull/8269

   ### What changes were proposed in this PR?
   
   Require the complete ten-byte Texera pickle header before unpickling an 
Arrow binary value. Raw bytes that merely begin with `pickle` now remain 
unchanged.
   
   The existing round-trip test still covers encoded Python objects, ordinary 
bytes, prefixed bytes, and null values.
   
   ### Any related issues, documentation, discussions?
   
   Closes #8268
   
   ### How was this PR tested?
   
   The untouched live probe raised `_pickle.UnpicklingError` for 
`b"picklehello"`. After the fix it reported `decoded=b"picklehello"`.
   
   `C:\Users\carlo\texera\texera\.venv312\Scripts\python.exe -c "import 
sys,pytest; 
sys.path[:0]=[r'C:\Users\carlo\texera\texera-worktrees\investigate-bug70\amber\src\main\python',r'C:\Users\carlo\texera\texera\amber\src\main\python'];
 raise 
SystemExit(pytest.main([r'amber/src/test/python/core/models/test_tuple.py','-q','-k','not
 test_hash','-p','no:cacheprovider']))"`
   
   Result: 101 passed and 2 deselected. The excluded upstream Windows timestamp 
hash tests are covered by PR #8174.
   
   `C:\Users\carlo\texera\texera\.venv312\Scripts\ruff.exe check 
amber/src/main/python amber/src/test/python`
   
   `C:\Users\carlo\texera\texera\.venv312\Scripts\ruff.exe format --check 
amber/src/main/python/core/models/tuple.py 
amber/src/test/python/core/models/test_tuple.py`
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: OpenAI Codex


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to