kz930 opened a new pull request, #8285: URL: https://github.com/apache/texera/pull/8285
### What changes were proposed in this PR? Turning on `Split Plot by Line Group` makes `Line Group` required, because code generation asserts it and the run ends on `Line Group cannot be empty`. The field is declared `@JsonProperty(required = false)` and carried no conditional constraint, so the property panel accepted the configuration and the error waited for the run. A field that is optional is exactly the one a user leaves behind. The schema states the rule instead, in the conditional form the Sklearn text columns already use (#7643): `required: ["lineGroup"]` under `facetColumn`, so the panel refuses the configuration while it is being written. Conditional rather than a plain required, so a freshly dropped operator, whose switch is off, is not flagged for a field it has no use for. The assertion stays as the last line of defence, and the two tests that pin it stay with it. Nothing about the generated Python changes. One thing worth noting beyond the panel: a rule stated in the schema is one the tooling can read. Our translator's configuration generator fills a conditionally-required field from exactly this shape, which is how it fills the Sklearn text columns under Count Vectorizer; the assertion in Scala was invisible to it. ### Any related issues, documentation, discussions? Closes #8283. Same shape as #7643, which stated the Sklearn rule. ### How was this PR tested? `FilledAreaPlotOpDescSpec` gains an assertion on the generated schema: the line group is not unconditionally required, and the conditional rule requires it under the switch. Removing the annotation turns that test red. `WorkflowOperator/test` passes: 2517 tests. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
