Yicong-Huang commented on code in PR #7785:
URL: https://github.com/apache/texera/pull/7785#discussion_r3895052254
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/common/PekkoActorService.scala:
##########
@@ -23,7 +23,6 @@ import org.apache.pekko
import pekko.actor.{ActorContext, ActorRef, Address, Cancellable, Props}
import pekko.util.Timeout
Review Comment:
`ask` was the only member here needing an implicit `Timeout`, so `implicit
val timeout` on :34 is dead too, and this import exists only to type it.
Nothing outside resolves it: no `actorService.timeout` under `amber/src`,
and `WorkflowActor.scala:90` declares its own for the `?` on :93. Dropping :34
also frees `DurationInt` on :28.
The build can't catch this — the import is still used by the dead val, and
Scala doesn't warn on an unused public val.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
