aglinxinyuan commented on PR #8293:
URL: https://github.com/apache/texera/pull/8293#issuecomment-5481207611
Two things: this PR's own CI is not verifying it, and here is the
verification it is missing.
### Why its CI proves nothing
Every stack skipped on the latest run. The precheck log says why:
```
PR labels: fix, release/v1.2
Stacks selected by label union: (none)
```
The `pyamber` label is what selects the pyamber stack (`LABEL_STACKS` in
`precheck.yml:261`). It was on this PR — I added it by hand at 14:45:54 — and
then:
```
2026-08-31T14:45:54Z labeled pyamber by aglinxinyuan
2026-08-31T16:12:10Z unlabeled pyamber by github-actions[bot]
```
`.github/workflows/pr-labeler.yml:31` sets `sync-labels: true`, and the
`pyamber` globs in `.github/labeler.yml:102-106` are `amber/**/*.py`,
`amber/pyproject.toml`, `amber/**/*requirements*.txt`.
`amber/LICENSE-binary-python` matches none of them, so the labeler removed the
label as not-applicable. Precheck then does exactly what it is designed to do —
waits for the labeler to finish *because it may have just added labels* — and
reads the post-strip set.
So the manual-label workaround does not hold: it survives until the next
`pull_request` event and is then swept. That makes #8294 sharper than "these
edits skip the checks" — there is currently no way to make the stack run on a
LICENSE-binary-only PR without touching `.github/labeler.yml`.
### The verification, run locally
`check_binary_deps.py` accepts `--license-binary`, so the real checker can
be pointed at each side of this diff. Input is a `pip-licenses` CSV built from
the 109 packages the pre-fix manifest claims, plus the one new distribution CI
reported:
**Pre-fix manifest (`origin/main`)** — reproduces the CI failure line
verbatim:
```
NEW Python packages not claimed by LICENSE-binary:
+ cloudpickle==3.1.2 (license: BSD License) → add to .../A-prefix.txt
exit=1
```
**Post-fix manifest (this PR)** — same input, same command:
```
OK: 110 Python packages match LICENSE-binary.
exit=0
```
That 110 is the same count the description quotes from a passing run, which
is a useful cross-check that the synthesized package set matches the real
installed one.
Reproducible from the repo root:
```bash
git show origin/main:amber/LICENSE-binary-python > /tmp/A.txt
git show HEAD:amber/LICENSE-binary-python > /tmp/B.txt
# build /tmp/pip-licenses.csv = every "- name==ver" bullet under a "Python
packages:"
# heading in /tmp/A.txt, plus cloudpickle,3.1.2,"BSD License"
./bin/licensing/check_binary_deps.py --ignore-transitive-version python
/tmp/pip-licenses.csv --license-binary /tmp/A.txt # exit 1
./bin/licensing/check_binary_deps.py --ignore-transitive-version python
/tmp/pip-licenses.csv --license-binary /tmp/B.txt # exit 0
```
I have not re-added the `pyamber` label, since it would just be swept again
on the next event. Whether the labeler glob gets widened here or under #8294 is
a maintainer call — happy to do either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
