aglinxinyuan commented on issue #8294:
URL: https://github.com/apache/texera/issues/8294#issuecomment-5481212944
One correction that strengthens the case: the hand-applied label does
**not** work around this. The issue reads "the `pyamber` label had to be
applied by hand for the fix to be tested at all" — it was applied by hand, and
#8293 still ran nothing.
`.github/workflows/pr-labeler.yml:31` sets `sync-labels: true`, so the
labeler removes labels whose globs no longer match — including ones a human
added:
```
2026-08-31T14:45:54Z labeled pyamber by aglinxinyuan
2026-08-31T16:12:10Z unlabeled pyamber by github-actions[bot]
```
And the sweep wins the race by design. `precheck` waits for the labeler to
finish before reading labels — the comment at `precheck.yml:201` says
*"Re-fetch labels: the labeler may have just added some"* — so it reads the set
**after** the sweep:
```
PR labels: fix, release/v1.2
Stacks selected by label union: (none)
```
So the sequence is:
```
human adds pyamber -> next pull_request event -> labeler sweeps it (no
matching glob)
-> precheck waits for labeler, re-fetches -> (none) ->
every stack skipped
```
Two consequences for the fix:
1. There is no operator-side workaround today. Widening the globs isn't
hygiene, it's the only route — a maintainer cannot force the stack on a
LICENSE-binary-only PR, and re-labelling after the sweep only holds until the
next event.
2. `--label` on the PR at creation time fares no better, since the sweep
happens on subsequent events.
Meanwhile #8293's one-line change is verified out-of-band:
`check_binary_deps.py` takes `--license-binary`, so pointing the real checker
at each side of the diff with a `pip-licenses` CSV built from the manifest's
own 109 packages plus `cloudpickle==3.1.2` gives `exit=1` with the exact CI
line before and `OK: 110 Python packages match LICENSE-binary.` after. Details
in https://github.com/apache/texera/pull/8293#issuecomment-5481207611. That is
a workaround for one PR, not for the gap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
