carloea2 commented on code in PR #8138:
URL: https://github.com/apache/texera/pull/8138#discussion_r3897023738
##########
amber/src/main/scala/org/apache/texera/web/resource/dashboard/hub/HubResource.scala:
##########
@@ -646,6 +646,11 @@ class HubResource {
@QueryParam("entityType") entityTypes: java.util.List[EntityType],
@QueryParam("entityId") entityIds: java.util.List[Integer]
): java.util.List[AccessResponse] = {
+ if (entityTypes.size() != entityIds.size())
Review Comment:
Added the same length check to isLikedHelper and covered both mismatch
directions.
##########
amber/src/main/scala/org/apache/texera/web/resource/dashboard/hub/HubResource.scala:
##########
@@ -646,6 +646,11 @@ class HubResource {
@QueryParam("entityType") entityTypes: java.util.List[EntityType],
@QueryParam("entityId") entityIds: java.util.List[Integer]
Review Comment:
Documented the equal length requirement and BadRequestException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
