Yicong-Huang commented on code in PR #8136:
URL: https://github.com/apache/texera/pull/8136#discussion_r3897822453
##########
amber/src/main/scala/org/apache/texera/web/resource/dashboard/hub/HubResource.scala:
##########
@@ -408,6 +408,7 @@ class HubResource {
* @return A Map from each actionType.value (e.g. "like",
"clone")
* to a List of DashboardClickableFileEntry containing
the top 8
* public entities of that type.
+ * @throws javax.ws.rs.BadRequestException if entityType is missing
Review Comment:
`getTops` throws `BadRequestException` a second time — for an unsupported
`actionType` at `:449-451` — and the sibling `getCounts` enumerates both of its
conditions at `:515-516`. This tag names one of the two.
My miss last round: I asked for exactly the line you added and did not
notice the second throw.
```suggestion
* @throws javax.ws.rs.BadRequestException if entityType is missing, or
if actionTypes
* contains an unsupported value.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
