Yicong-Huang commented on code in PR #8140:
URL: https://github.com/apache/texera/pull/8140#discussion_r3897827215
##########
amber/src/test/scala/org/apache/texera/web/resource/dashboard/file/WorkflowResourceSpec.scala:
##########
@@ -1022,6 +1022,12 @@ class WorkflowResourceSpec
assert(workflowResource.getWorkflowType(wid) == "Private")
}
+ it should "hide private and missing workflows from public retrieval" in {
Review Comment:
`it` binds to the previous subject — `"WorkflowResource.makePublic /
makePrivate"` at :1013 — so this case reports under a method it never touches,
and `retrievePublicWorkflow` gets no subject of its own.
Renaming the subject here won't work. The next test at :1031 is a
`makePublic` case and would silently inherit it. Move this block below :1034
instead, and give it a `"WorkflowResource.retrievePublicWorkflow" should`
subject.
Our round-2 comment is what put it here, so this one is ours to sweep up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
