mengw15 commented on code in PR #8275:
URL: https://github.com/apache/texera/pull/8275#discussion_r3899811573
##########
frontend/src/app/workspace/service/workflow-graph/model/workflow-action.service.ts:
##########
@@ -763,6 +803,7 @@ export class WorkflowActionService {
links,
commentBoxes,
settings,
+ formBinding: this.formBinding,
Review Comment:
This emits `formBinding` unconditionally, so every workflow's next save
stamps `{"fields":[],"resultOperatorIds":[]}` into its content — the first
post-deploy save of every existing workflow diffs and cuts a version row, and
the type's own docstring ("Present once an author set up the Form View") stops
being true. It also inverts the rule agent-service follows in this same PR
(re-emit only when the loaded content carried one). Worth emitting the key only
when the definition is non-empty or was present on load.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
