aglinxinyuan opened a new pull request, #8333: URL: https://github.com/apache/texera/pull/8333
### What changes were proposed in this PR? `PropertyNameConstants` declares 21 constants; only two are referenced anywhere outside its own spec. This removes the other 19. Pure deletion, no behaviour change: **−95 lines**. `LogicalOp` uses `OPERATOR_ID` and `OPERATOR_VERSION` as `@JsonProperty` annotation arguments — those are live and stay. Each of the other 19 has exactly three references, all inside `PropertyNameConstantsSpec`. **Provenance.** The object arrived with the original amber import (2020-08-20) as the intended single source of truth for operator-JSON key names. Operator descriptors never adopted it — they spell their JSON keys as raw string literals, and the wire format is anchored elsewhere: `@JsonTypeInfo(property = "operatorType")` in `LogicalOp`, plus literals in `OperatorMetadataGenerator` and `WorkflowResource`. So these constants were never the source of truth they were meant to be, which is why deleting them cannot change the serialized format. > Reviewer note: `TABLE_NAME` **is** included. Its only qualified references are in the spec; the bare `TABLE_NAME` hits elsewhere are an unrelated SQL placeholder in `sql/misc/tweets.sql`. The spec keeps its three tests, narrowed to the two surviving constants — including the distinctness and whitespace checks, which still hold. ### Any related issues, documentation, discussions? Closes #8330 ### How was this PR tested? Existing tests only — this PR adds none; it narrows the assertions to the constants that remain. Locally, from the repo root with Java 17: - `sbt "WorkflowExecutionService/Test/compile"` — success. - `sbt "WorkflowOperator/testOnly *PropertyNameConstantsSpec"` — 3 tests, all pass. - `sbt scalafmtCheckAll "scalafixAll --check"` — clean. Verification, re-runnable by a reviewer: ``` git grep -oh "PropertyNameConstants\.[A-Z_]*" -- . ':!*PropertyNameConstants.scala' | sort | uniq -c ``` Before this change every constant shows exactly 3 hits (its spec assertions) except `OPERATOR_ID` and `OPERATOR_VERSION`, which show 4 — the extra one being `LogicalOp`. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
