tanishqgandhi1908 opened a new pull request, #8343:
URL: https://github.com/apache/texera/pull/8343
### What changes were proposed in this PR?
The version dropdown on a dataset's detail page carried nzAllowClear, so
clicking the × emitted null into onVersionSelected(version: DatasetVersion),
which read this.selectedVersion.dvid and threw an uncaught TypeError. The page
was left half-cleared: the main pane said "No version is selected" while the
header still showed the cleared version's file path and the file tree still
listed its files.
Clearing the selection is not a meaningful action on a page whose entire
content is one version, so the button goes away. The model detail page already
works this way.
dataset-detail.component.html — drop nzAllowClear from the version nz-select.
dataset-detail.component.ts — onVersionSelected takes DatasetVersion |
undefined and skips the fetch when there is no dvid, so an empty selection
cannot throw even if the control pushes one (an empty version list, for
instance). Mirrors model-detail.component.ts.
Picking a version behaves exactly as before: same request, same arguments.
Before — the × in the dropdown, and the page after clicking it (console
output overlaid so it fits in one screenshot):
<img width="1440" height="900" alt="image"
src="https://github.com/user-attachments/assets/8780a9e5-e135-4281-9120-9cbe898639c4";
/>
<img width="1440" height="900" alt="image"
src="https://github.com/user-attachments/assets/3edcf630-fc06-4c5f-9bab-e916f10e03c7";
/>
After — same dropdown hovered, no clear button:
<img width="1440" height="900" alt="image"
src="https://github.com/user-attachments/assets/a837ab1e-06b8-4d8c-a43e-540c4142b51f";
/>
### Any related issues, documentation, discussions?
Closes #8342
### How was this PR tested?
Two cases added to dataset-detail.component.spec.ts:
survives the version select being emptied — onVersionSelected(undefined)
neither throws nor fetches. Without the signature change it does not compile.
offers no way to empty the selection — the rendered picker has no clear
control.
```
cd frontend
npx ng test --include
src/app/dashboard/component/user/user-dataset/user-dataset-explorer/dataset-detail.component.spec.ts
# Tests 144 passed (144)
```
Also checked by hand against a local stack: hovering the version dropdown on
a dataset with two versions no longer offers a ×, switching versions still
reloads the file tree and preview, and the console stays clean.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
