PG1204 commented on code in PR #8301:
URL: https://github.com/apache/texera/pull/8301#discussion_r3930546770
##########
frontend/src/app/workspace/types/execute-workflow.interface.ts:
##########
@@ -93,9 +92,21 @@ export interface OperatorStatistics
aggregatedIdleTime?: number;
}> {}
+/**
+ * Wire shape of one operator's entry in OperatorStatisticsUpdateEvent. The
Review Comment:
addressed in
[f55bf88](https://github.com/apache/texera/pull/8301/commits/f55bf88f1795b7f930cfbd7b2ac4a2f045e88156)
##########
frontend/src/app/workspace/component/workflow-editor/workflow-editor.component.spec.ts:
##########
@@ -898,21 +899,15 @@ describe("WorkflowEditorComponent", () => {
* default (gray) when the user navigates away from and back to a workflow
* that has already finished executing. Both the operator-add stream and
* the validation stream route their final border decision through
- * applyOperatorBorder, which encodes the priority: invalid > cached
+ * applyOperatorStateAndBorder, which encodes the priority: invalid >
cached
* execution state > default valid. These tests assert the operator's
* actual final rect.body/stroke on the paper, so they pin down the visible
* outcome rather than the internal helper calls.
*/
describe("operator border restoration after navigation", () => {
let workflowStatusService: WorkflowStatusService;
const cachedStatus = (operatorState: OperatorState) => ({
Review Comment:
addressed in
[f55bf88](https://github.com/apache/texera/pull/8301/commits/f55bf88f1795b7f930cfbd7b2ac4a2f045e88156)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
