carloea2 commented on code in PR #8151:
URL: https://github.com/apache/texera/pull/8151#discussion_r3935988304
##########
amber/src/main/scala/org/apache/texera/web/resource/dashboard/DashboardResource.scala:
##########
@@ -158,7 +158,7 @@ object DashboardResource {
})
case None => List()
}
- case _ => List() // Default case if the orderBy string doesn't match the
pattern
+ case _ => throw new BadRequestException(s"Unknown orderBy:
${searchQueryParams.orderBy}")
Review Comment:
Both fallback paths now return 400. I also documented the empty value
behavior and fixed the stale spec comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
