mengw15 commented on code in PR #8351:
URL: https://github.com/apache/texera/pull/8351#discussion_r3936781503
##########
frontend/src/app/workspace/service/workflow-graph/model/workflow-action.service.ts:
##########
@@ -667,7 +678,7 @@ export class WorkflowActionService {
}
const workflowContent: WorkflowContent = workflow.content;
- this.workflowSettings = workflowContent.settings ||
this.getDefaultSettings();
+ this.setWorkflowSettings(workflowContent.settings);
Review Comment:
`hydrateFormBinding` maps absent → delete, so opening a workflow whose DB
copy carries no binding writes no op and can't disturb a co-editor's live one.
The settings seed doesn't get the same treatment: absent → `set(defaults)`
writes a real entry, concurrent with whatever a co-editor holds, so opening a
workflow that never saved settings while another editor has just tuned theirs
can revert them — the same open-time clobber this PR removes for formBinding.
Worth mirroring the delete here; `getWorkflowSettings` already defaults on an
absent key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
