Yicong-Huang commented on code in PR #8396:
URL: https://github.com/apache/texera/pull/8396#discussion_r3937094043
##########
amber/src/main/scala/org/apache/texera/web/TexeraWebApplication.scala:
##########
@@ -125,7 +125,6 @@ class TexeraWebApplication
environment.servlets.setSessionHandler(new SessionHandler)
Review Comment:
**Must fix:**
"never-registered" is refuted by git: `TexeraWebApplication` registered this
class live from `41a8a9201` (2020-08-20) until `4a64935c3` (2021-01-30).
"commented-out" is both accurate and the stronger claim, since the file defines
nothing at all. Suggested: `chore(amber): remove the commented-out
MockKillWorkerResource`. Type and scope are correct and stay.
##########
amber/src/main/scala/org/apache/texera/web/TexeraWebApplication.scala:
##########
@@ -125,7 +125,6 @@ class TexeraWebApplication
environment.servlets.setSessionHandler(new SessionHandler)
Review Comment:
**Must fix:**
Both commits the History table attributes are wrong. `134bc9ba64` replaced
the named import with a wildcard, and
`environment.jersey().register(classOf[MockKillWorkerResource])` is still an
uncommented line in that same diff. #1394 (`88ff5c840`) only reindented a
placeholder that #1000 (`4a64935c3`) had created. #1000 is the commit that
actually ended this code and the table never names it. That also corrects "dead
for about six years" to roughly 4.6. Issue #8393 carries the same text.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
