Yicong-Huang commented on code in PR #8379:
URL: https://github.com/apache/texera/pull/8379#discussion_r3937359415
##########
.asf.yaml:
##########
@@ -69,20 +69,76 @@ github:
rebase: false
rulesets:
- - name: Merge Queue
+ # Rule-for-rule identical to "Merge Queue" below; split out so the bypass
+ # here stays off main. The bypass exempts actions performed as the GitHub
+ # Actions app — i.e. any workflow's GITHUB_TOKEN, which is what
+ # direct-backport-push.yml's fast path pushes with (#8377). It cannot be
+ # scoped to a single workflow. People and PATs still face every rule.
+ #
+ # Listed BEFORE "Merge Queue" deliberately: asfyaml applies rulesets in
Review Comment:
**Advisory:**
This comment makes file order load-bearing and names the failure mode. The
one check that would catch a reorder cannot see order:
`test_asf_rulesets.sh:77` keys the rulesets into a dict. Both the
rules-equality and the new bypass-placement assertions then run on an
order-free view, so an edit that alphabetises the rulesets stays green while
removing the fail-safe. Asserting that "Merge Queue (release)" precedes "Merge
Queue" is a two-line addition beside `test_asf_rulesets.sh:93`.
##########
amber/dev-requirements.txt:
##########
@@ -39,3 +39,5 @@ betterproto[compiler]==2.0.0b7
# Required by `bin/local-dev.sh -i` (the interactive Textual TUI).
textual==8.2.8
+# .github/scripts/test_asf_rulesets.sh (infra job shell tests)
Review Comment:
**Polish:**
Every other comment and pin group in this file is blank-line separated
(`:22`, `:27`, `:31`, `:35`, `:39`). This entry reads as part of the `textual`
group.
```suggestion
# .github/scripts/test_asf_rulesets.sh (infra job shell tests)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
