VuMartin commented on code in PR #8398:
URL: https://github.com/apache/texera/pull/8398#discussion_r3938830289
##########
amber/src/main/scala/org/apache/texera/web/resource/dashboard/user/workflow/WorkflowResource.scala:
##########
@@ -848,6 +848,9 @@ class WorkflowResource extends LazyLogging {
@Path("/type/{wid}")
def getWorkflowType(@PathParam("wid") wid: Integer): String = {
val workflow: Workflow = workflowDao.fetchOneByWid(wid)
+ if (workflow == null) {
+ throw new NotFoundException(s"Workflow with id $wid not found")
Review Comment:
retrievePublicWorkflow is already covered by #8140, which is currently open.
Since #8300 is the follow-up for the getWorkflowType issue identified during
that review, should I leave the retrievePublicWorkflow fix scoped to #8140?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
