mengw15 commented on PR #8436: URL: https://github.com/apache/texera/pull/8436#issuecomment-5550682023
This PR's own goal is that a property renders the same control in both views, so I want to question the two planned exceptions. (1) The code box is banned from exposure entirely — I'd rather drop that and let the author decide: choosing what to expose is already the author's call, property by property. The render slice also has to handle an exposed code key anyway (formBinding is data — an older client or a hand-edited config can put one there), so blocking it at choose time doesn't actually protect the form. (2) The description says Projection's reorder list will render in the form without the drag — why not with it? The widget sits in the same global formly registry as every other one here; the form only needs to wire its own reorder callback, the same way the panel wires its own. If both properties just render their real widgets, neither special rule is needed. I'd like to settle this before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
