yangzhang75 commented on PR #8437: URL: https://github.com/apache/texera/pull/8437#issuecomment-5557544452
Thanks both. Addressed in the latest push (force-pushed), with a follow-up issue (#8439) for the two refinements that touch shared code. **Fixed here:** - **Read-only controls stayed interactive** (Copilot). Confirmed and fixed. `form.disable()` on the still-empty FormGroup was a no-op: formly builds its controls after that, and a control added to an already-disabled group comes back enabled (verified in isolation: `control.disabled` false, and the group re-enables itself). Switched to `field.props.disabled = true`, which formly honours and which cascades to a nested property's sub-fields. For the extra elements a custom widget draws of its own (a file picker's Browse button, an uploader) that do not consult the form's disabled state, the read-only card now also carries `pointer-events: none`, so nothing inside it is interactive. - **HuggingFace model picker lacked operator context** (Copilot). Right: the widget reads `task` from its model or a sibling control, and the isolated per-input model had neither, so it defaulted to text-generation. The field's model is now seeded with the operator's other properties (`task` included) as read-only context, so it loads the right models and labels the field; only the bound property is written back, and the context is cloned so the widget cannot reach the real operator. The remaining piece, a form-view mode that also hides or locks the task selector so a task change cannot desync, touches the shared widget and is filed as #8439. - **Binding-change stream and typing** (mengw15, Copilot). Correct on both: this stream is not live for a co-editor until #8351 moves formBinding into the shared model, and when it goes live it needs the same typing skip the compilation path has. Added the `isTypingInTheForm()` skip here, and the comment now says it fires for this client today and for co-editors once #8351 lands. - **Per-field guidance** (mengw15's question). The reader's guidance is the author's help text, which was carried on the binding but not rendered. It now renders under each input; the schema's own field descriptions stay dropped, since those are operator-author notes, not reader guidance. The markdown instruction above the inputs is the next PR (#8023). **Left as-is, with reasons:** - **Compilation update dropped while typing** (Copilot). A state update that lands mid-typing is skipped and not replayed. It is an edge (the next compilation refreshes it), and the pending-rebuild-on-blur fix is filed in #8439 rather than added to this slice. - **Hidden bindings** (mengw15). There is no binding-level `hidden` on `FormFieldBinding` today. `hidden` lives on the per-sub-field `FormFieldOverride`, which PR11 (#8438) already honours in the sub-field walk. So there is nothing at the binding level to filter yet; when authoring adds a way to hide a whole input, the filter goes in with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
