aglinxinyuan opened a new pull request, #8465:
URL: https://github.com/apache/texera/pull/8465
### What changes were proposed in this PR?
Deletes two large commented-out test blocks from
`workflow-editor.component.spec.ts`. Neither can be re-enabled as written, and
both have live replacement coverage. Pure deletion, no behaviour change: **−225
lines**.
### History
| | |
| --- | --- |
| **Block 708-822** (copy/cut/paste) | Commented out when written, by #1619
(2022-09-13, "Copy and Paste Operators with System Clipboard") — its header
says the new clipboard path "would not pass this unit test, since write access
to the system clipboard is needed". **Superseded**: the live
`describe("clipboard")` block in this same file covers all three cases (copy,
cut, paste), and the paste-offset property is covered in
`operator-menu.service.spec.ts` against the real `findNonOverlappingPosition`
logic |
| **Block 531-638** (`xdescribe("when executionStatus is enabled")`) |
Commented out on 2020-08-01 (`a9c404764a`) — about six years. **Cannot be
revived**: it spies on `changeOperatorStates` / `OperatorStates` (plural) while
the live code has `changeOperatorState` / `OperatorState` (singular), and it
calls `TestBed.get`, an API Angular has since removed |
Neither block is executable: re-parsing the file with the repo's own
TypeScript finds zero live tokens in either range, so neither registers with
Vitest and neither can appear in `junit.xml` or any skipped-test count.
> Reviewer note: the ranges were deleted **bottom-up** (708-823 first, then
531-639), each including its one trailing blank line. Line 707 and line 530 are
already blank, so deleting only the comment ranges would leave doubled blank
lines and fail `yarn format:ci` — confirmed empirically with `prettier --check`
on both variants. The live `describe("clipboard")` block and the standing note
about clipboard cases needing a real browser are kept.
### Any related issues, documentation, discussions?
Closes #8461
### How was this PR tested?
Existing tests only — this PR removes commented text that runs nothing.
From `frontend/`:
- `npx ng test --watch=false
--include='**/workflow-editor.component.spec.ts'` — 106 tests pass, unchanged
from before.
- `yarn --cwd frontend format:ci` — clean (this is the gate the blank-line
handling protects).
Verification, re-runnable by a reviewer:
```
grep -c "xdescribe\|the new method of copying"
frontend/src/app/workspace/component/workflow-editor/workflow-editor.component.spec.ts
# 0
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
