Copilot commented on code in PR #8238:
URL: https://github.com/apache/texera/pull/8238#discussion_r3969465490
##########
amber/src/main/python/core/storage/vfs_uri_factory.py:
##########
@@ -88,7 +88,7 @@ def extract_value(key: str) -> str:
else None
)
- resource_type_str = segments[-1].lower()
+ resource_type_str = segments[-1]
try:
resource_type = VFSResourceType(resource_type_str)
except ValueError:
Review Comment:
Removing `.lower()` fixes camel-case resource types, but it also makes
decoding fully case-sensitive, which is a backwards-incompatible behavior
change for any callers that previously relied on mixed/upper-case URIs being
accepted. Consider a two-step parse: first try the exact segment (to preserve
camel-case), and if that fails, fall back to `lower()`/`casefold()` before
raising, so you keep the new behavior while retaining prior tolerance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
