mengw15 commented on code in PR #8442:
URL: https://github.com/apache/texera/pull/8442#discussion_r3982235511
##########
frontend/src/app/workspace/component/property-editor/operator-property-edit-frame/operator-property-edit-frame.component.ts:
##########
@@ -178,6 +178,11 @@ export class OperatorPropertyEditFrameComponent implements
OnInit, OnChanges, On
/** True while an author is choosing which properties appear on the Form
View; adds a tick
* box beside each. Off, the property editor is unchanged. */
@Input() exposeChoosing = false;
+ /** Whether opening an operator may write to the shared workflow: the
"currently editing" co-editor
+ * broadcast AND the operator-version sync (both are shared-model writes).
True on the operator
+ * canvas; the Form View sets it false to inspect a step read-only, so
opening one neither shows
+ * the reader as a co-editor nor mutates the operator's version. */
+ @Input() broadcastEditing = true;
Review Comment:
Naming thought while this input is a day old: `broadcastEditing` now gates
more than broadcasting — the version sync is a persistent document write, and
the defaults fix will make it three. A later change could add a write outside
the gate believing this flag only controls the presence badge. Something like
`actsAsEditor` says what it decides: whether opening the panel behaves as an
editor (presence, version sync, defaults materialisation) or as a pure viewer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
