yangzhang75 commented on code in PR #8516:
URL: https://github.com/apache/texera/pull/8516#discussion_r3994015702
##########
frontend/src/app/workspace/service/form-binding/form-binding.service.ts:
##########
@@ -179,17 +179,29 @@ export class FormBindingService {
}
/**
- * Choose whether an operator's output is shown on the form after a run.
This records the
- * form's own selection only and never changes the canvas's view-result
flags: the form
- * offers exactly the operators the workflow already views, so their results
are already
- * materialised and nothing here needs to touch the graph. Read-only, one
direction.
+ * Choose whether an intermediate operator's output is featured on the form
after a run, on top of
+ * the final steps' results, which show by default. This records the form's
own selection only and
+ * never changes the canvas's view-result flags: the picker offers
view-result operators, whose
+ * results are already materialised, so nothing here needs to touch the
graph. Read-only, one
+ * direction.
*/
public toggleResultOperator(operatorID: string): void {
const shown = this.getConfig().resultOperatorIds;
const next = shown.includes(operatorID) ? shown.filter(id => id !==
operatorID) : [...shown, operatorID];
this.updateConfig({ resultOperatorIds: next });
}
+ /**
+ * Turn a final step's result off, or back on. A final step shows by default
(the engine always
+ * materialises it), so only the "off" is recorded: a step that becomes
final later shows without
+ * being listed anywhere.
+ */
+ public toggleHiddenResult(operatorID: string): void {
Review Comment:
Good catch, and the path is real. Fixed in 403bbb534 at the sink, both ways:
toggleHiddenResult also drops the id from resultOperatorIds, and
toggleResultOperator clears an earlier off entry (the off list is still only
created by an explicit off). Spec covers the round trip and the deletion checks
for both directions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
