zyratlo opened a new issue, #8543:
URL: https://github.com/apache/texera/issues/8543

   ### Feature Summary
   
   The migration tool was built when a Jupyter notebook was the only accepted 
input, and its naming reflects that throughout. Now that we are supporting 
Python files (#8007), Python folders (#8008), and R (#8009), a user who uploads 
a `.py` or `.R` still sees a panel titled "Jupyter Notebook", a button labelled 
"expand Jupyter notebook", and a confirmation asking whether to delete "this 
workflow's Jupyter notebook".
   
   The naming is not wrong internally: a script really is converted into a 
notebook so that the existing mapping and panel work unchanged. It is wrong 
from the user's side, because they never uploaded a notebook.
   
   ### Proposed Solution or Design
   
   Replace the user-facing copy that names the input type, in two places:
   
   * `jupyter-notebook-panel.component.html`: the panel header, the iframe 
`title`, the delete tooltip, and the delete confirmation text
   * `menu.component.html`: the toolbar button's `title` (two selectors in 
`menu.component.spec.ts` key off it)
   
   Two related items to decide when this is picked up:
   
   * The toolbar button uses the Jupyter logo (`jupyter-logo.svg`). A Jupyter 
logo next to a generalized label is unsuitable for a script, and more so for R. 
Replacing it means sourcing an icon and updating `.licenserc.yaml` and 
`frontend/LICENSE-binary`.
   * Whether to stop at display strings or also rename identifiers: 
`JupyterNotebookPanelComponent`, `JupyterPanelService`, `notebookFileName`, the 
`notebook` and `workflow_notebook_mapping` tables, and the 
`/notebook-migration` endpoints. These are accurate at the implementation 
level, so renaming them is a larger and riskier change that should be weighed 
separately rather than assumed.
   
   ### Affected Area
   
   Other


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to