mengw15 commented on code in PR #8551:
URL: https://github.com/apache/texera/pull/8551#discussion_r4041824134
##########
frontend/src/app/workspace/component/menu/menu.component.ts:
##########
@@ -408,6 +421,18 @@ export class MenuComponent implements OnInit, OnDestroy {
};
}
+ // Per-user warehouses enabled but none to write to (#7817): mirror the
+ // Connect state above — name the fixing action, and runWorkflow() routes
+ // the click into the create-warehouse modal.
+ if (this.computingUnitSelectionComponent?.warehouseRequiredButMissing) {
Review Comment:
Done — the gate now applies only in the five run-starting states (exactly
your suggestion), so Pause/Resume/Kill keep the button mid-execution. Covered
by a regression test: Running with the warehouse gone still renders Pause.
##########
frontend/src/app/workspace/service/execute-workflow/execute-workflow.service.ts:
##########
@@ -230,6 +240,22 @@ export class ExecuteWorkflowService {
);
}
+ /**
+ * While the deployment requires a warehouse (#7817) and none is picked,
+ * refuses with a toast and returns true. Checked at every public entry
+ * point before it resets the previous execution's state — a refused click
+ * must not wipe the results already on screen — and again in
+ * sendExecutionRequest as the shared belt (#7751 adds the backend-side
+ * rejection).
+ */
+ private refuseToRunWithoutWarehouse(): boolean {
+ if (!this.config.env.warehouseEnabled ||
this.warehouseService.getSelectedWarehouseIdValue() !== undefined) {
Review Comment:
Agreed these are two client signals for one gate. Leaving as-is for now:
both trace to `StorageConfig.warehouseEnabled`, and the authoritative gate
moves server-side with #7751 — an execution without a warehouse gets rejected
there regardless of client signals, so drift can at worst cost an extra toast.
If `status.enabled` ever becomes dynamic or per-user, unifying both consumers
on a single `WarehouseService`-owned signal is the right move.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
