kunwp1 commented on code in PR #8586:
URL: https://github.com/apache/texera/pull/8586#discussion_r4049609504
##########
amber/src/main/scala/org/apache/texera/web/service/WorkflowService.scala:
##########
@@ -89,6 +95,11 @@ object WorkflowService {
)
return None
}
+ if (warehouseId.isEmpty) {
Review Comment:
I can see this guard is needed in `executeWorkflowSync` and
`WorkflowWebsocketResource` because if a user was running an execution and
during the execution the user asks to to run something through agent, if the
agent doesn't carry a warehouse, it will kill the existing execution and refuse
the request. This doesn't sound right.
##########
frontend/src/app/workspace/service/agent/agent.service.ts:
##########
@@ -666,6 +668,12 @@ export class AgentService {
if (selectedUnit) {
body.computingUnitId = selectedUnit.computingUnit.cuid;
}
+ // Same for the warehouse the user picked: agent runs write into it
rather than
+ // shared storage, which the backend requires while the feature is on
(#7751).
+ const selectedWarehouseId =
this.warehouseService.getSelectedWarehouseIdValue();
Review Comment:
I can see a scenario that an agent created before the warehouse list loads
can never run. A user opens a workflow, creates an agent, asks it to run but
she gets "a warehouse must be selected" while the canvas picker shows one
selected. Nothing in the agent panel lets her change it, so her only working
move is to delete the agent and make a new one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
