mengw15 commented on code in PR #8592:
URL: https://github.com/apache/texera/pull/8592#discussion_r4049790478
##########
frontend/src/app/workspace/component/workflow-form/workflow-form.component.ts:
##########
@@ -1566,6 +1574,10 @@ export class WorkflowFormComponent implements OnInit,
OnDestroy {
if (this.hasNoComputingUnit) {
return { label: "Connect", icon: "plus-circle", disabled: true };
}
+ // After the unit, as the canvas orders them: somewhere to compute before
somewhere to write.
Review Comment:
Done — `No access` now comes before the warehouse state. Picking a warehouse
is the only one of these a reader can act on, so naming it first would have
sent someone without write access to fix the wrong thing and hit the access
wall afterwards. Pinned by a test: a read-only unit with no warehouse says `No
access`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]