mengw15 opened a new issue, #8599:
URL: https://github.com/apache/texera/issues/8599

   ### What happened?
   
   The share dialog for a workflow no longer offers the Private / Public choice 
— the two buttons at the top of the dialog are simply not there. Everything 
else in it (the owner, the access list, the invite form) renders as usual, so 
nothing indicates that anything failed. Video attached.
   
   A guess at the cause, not verified: those buttons are rendered only once the 
dialog has read the workflow's current publish state (`*ngIf="isPublic !== 
null"`, `share-access.component.html`), and the subscription that fills it has 
no error handler, so a failed `GET /workflow/type/{wid}` would hide them with 
no sign of the failure. `WorkflowResource.getWorkflowType` reads 
`workflowDao.fetchOneByWid(wid)` and dereferences it without a null check, 
which throws for an id that matches no row. Worth checking that request in the 
network tab first.
   
   ### How to reproduce?
   
   Switch between the Canvas and the Form View, then open the share dialog. See 
the attached video.
   
   ### Version/Branch
   
   1.4.0-incubating-SNAPSHOT (main)
   
   ### Commit Hash (Optional)
   
   e7d1676e1
   
   ### What browsers are you seeing the problem on?
   
   Chrome
   
   ### Relevant log output
   
   ```
   Check the network tab for GET /api/workflow/type/{wid} while the dialog 
opens.
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to