yangzhang75 commented on PR #8607: URL: https://github.com/apache/texera/pull/8607#issuecomment-5739524619
Closing: the fix belongs in #8581 rather than beside it. The defect is older than #8581 (the lookup predates the `core/new-gui` relocation), but the symptom is #8581's: routing between a workflow's two views is what puts two editors in the page at once. A #8581 without this fix would merge a blank canvas into `main` and rely on this PR landing first, which nothing enforces. Carrying it there instead means `main` is never broken whatever order things land in, and 2 files / +32/-2 does not meaningfully add to that PR's review surface. The commit is unchanged, now the third on #8581's branch. #8606 stays open for the two other document-wide lookups of the same id, which #8581 does not need. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
