aglinxinyuan opened a new pull request, #8615: URL: https://github.com/apache/texera/pull/8615
### What changes were proposed in this PR? Removes the plumbing left behind when the link-breakpoint feature was deleted from the UI. None of these streams can emit — there is no `.next()` on any of them anywhere in production, so the getters hand out streams that never fire and `linksWithBreakpoints` is permanently empty. Pure deletion, no behaviour change: **−100 lines**. ### History | | | | --- | --- | | **Introduced by** | the original breakpoint implementation, commit `f80c9a43db` (2020-03-29) — predates the PR workflow | | **Usage removed by** | #2392 (2024-02-19) — "Remove breakpoint feature" deleted `setLinkBreakpoint` and the `breakpointChangeStream.next` producers. #3033 (2024-11-13) — "Remove Operator Group" then removed the last `jointLinkBreakpointShowStream.next` / `HideStream.next` calls | Since #3033 there has been no producer at all. | Removed | Where | | --- | --- | | `jointLinkBreakpointShowStream` / `HideStream` + their getters, and the `linkIDType` alias only they used | `joint-graph-wrapper.ts` | | `linksWithBreakpoints` + `getLinkIDsWithBreakpoint` | `joint-graph-wrapper.ts` | | `breakpointChangeStream` + `getBreakpointChangeStream`, and the `"setLinkBreakpoint"` / `"breakpointChangeStream"` entries in the restricted-method union | `workflow-graph.ts` | | the merge operand | `workflow-action.service.ts` | | `handleLinkBreakpointToggleEvents` + its call | `workflow-editor.component.ts` | > Reviewer note — one guard collapses rather than disappearing. The `link:mouseleave` handler skipped `hideTools()` for links that had a breakpoint; since `getLinkIDsWithBreakpoint()` always returns empty, that branch was always taken, so the call is now unconditional. Same behaviour, one branch fewer. The doc comment above it, which explained the breakpoint exception, is updated to match. > The `"setLinkBreakpoint"` union entry names a method that no longer exists — it is a string in a restricted-method union, not a call site. > These picked up coverage in #7481 (2026-08-09) and #6586 (2026-07-20), which is why they look live; those tests poke the dead subjects directly through `(wrapper as any)` rather than exercising a feature. ### Any related issues, documentation, discussions? Closes #8612 ### How was this PR tested? Existing tests only — this PR removes code and the tests that poked it. From `frontend/`: - `npx ng build` — **success**. This PR edits a component, so the AOT build is the gate that proves no template still binds to a removed member. - `npx ng test --watch=false --include='**/joint-graph-wrapper.spec.ts' --include='**/workflow-graph.spec.ts' --include='**/workflow-editor.component.spec.ts'` — 251 tests pass across the three files. - `yarn --cwd frontend format:ci` — clean. Verification, re-runnable by a reviewer: ``` git grep -n "LinkBreakpoint\|breakpointChangeStream\|linksWithBreakpoints\|linkIDType" ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
