yrenat commented on code in PR #6046:
URL: https://github.com/apache/texera/pull/6046#discussion_r4056141905
##########
computing-unit-managing-service/src/main/scala/org/apache/texera/service/ComputingUnitManagingService.scala:
##########
@@ -32,9 +32,65 @@ import org.apache.texera.service.resource.{
ComputingUnitManagingResource,
HealthCheckResource
}
+import
org.apache.texera.service.resource.ComputingUnitManagingResource.TerminatedComputingUnitInfo
+import org.slf4j.LoggerFactory
import java.nio.file.Path
+import java.util.concurrent.TimeUnit
class ComputingUnitManagingService extends
Application[ComputingUnitManagingServiceConfiguration] {
+ private val logger =
LoggerFactory.getLogger(classOf[ComputingUnitManagingService])
+
+ private def initSqlServer(): Unit =
+ SqlServer.initConnection(
+ StorageConfig.jdbcUrl,
+ StorageConfig.jdbcUsername,
+ StorageConfig.jdbcPassword
+ )
+
+ private[service] def registerIdleComputingUnitCleanup(
Review Comment:
Done. Sweep moved into `util/IdleComputingUnitCleanupJob` (`Managed` +
`LazyLogging` + `require` + daemon executor +
`runScheduledTick`/`runCleanupOnce`);
`registerIdleComputingUnitCleanup(environment, enabled, idleTimeoutMinutes,
intervalMinutes)` now aligns with `registerStagedFileCleanup`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
