yangzhang75 commented on issue #8439: URL: https://github.com/apache/texera/issues/8439#issuecomment-5783257410
A second way to item 1's missing editor host, found while auditing #8581. It is not only an exposed code property that reaches it: the Form View's step panel renders the operator's real property frame, and in edit mode (`panelLive`) that frame is interactive, so a Python UDF step shows the ordinary code-editor button. Pressing it calls `codeEditorService.vc.createComponent(...)` (`codearea-custom-template.component.ts:87`), and the only thing that ever sets `vc` is the canvas (`workspace.component.ts`, its `<ng-template #codeEditor>`). Two failure modes, both broken: before #8581 the Form View was a fresh page load, so `vc` was `undefined` and the click threw; with #8581 the canvas -> form switch routes, so `vc` is the destroyed canvas's `ViewContainerRef` (its `ngOnDestroy` clears the container but keeps the reference) and Monaco is created into a detached view -- nothing visible. Neither is a regression of #8581; it is the same missing host. Worth knowing when this is picked up: the button is reachable today, so hiding it in the form until the host exists is a cheap interim, and whatever host is added should be owned above both views (or handed over with the session) rather than by the canvas alone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
