pedroreyesalavrado commented on PR #8637:
URL: https://github.com/apache/texera/pull/8637#issuecomment-5802692873
Good catch, thanks. Fixed in `0eb0a3f60`.
`applyFix()` now applies the same staleness check to the property branch: it
compares the live field with the value captured when the suggestion was
generated, and refuses when they differ, so neither `setOperatorProperty` nor
`executeWorkflow` runs and the panel asks for a fresh analysis. That matches
what the code branch already did with its snippet.
Added the regression test you described — the target property changes
between analysis and Apply, and both calls are asserted absent — and
strengthened the existing unchanged-field test, which checked the write but not
the re-run or the resulting state.
Tests pass locally on the rebased branch:
cd frontend && yarn test
--include="src/app/workspace/component/result-panel/**/*.spec.ts"
Test Files 7 passed (7)
Tests 201 passed (201)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]