carloea2 commented on code in PR #8262:
URL: https://github.com/apache/texera/pull/8262#discussion_r4088765758
##########
amber/src/main/python/pytexera/storage/large_binary_manager.py:
##########
@@ -84,10 +85,20 @@ def _ensure_bucket_exists(self, bucket: str):
s3 = self._get_s3_client()
try:
s3.head_bucket(Bucket=bucket)
- except s3.exceptions.NoSuchBucket:
+ except ClientError as error:
+ if error.response["Error"]["Code"] not in (
+ "404",
+ "NoSuchBucket",
+ "NotFound",
Review Comment:
Removed the speculative NotFound case in 2dfd68bf6d. Added a regression
first: it failed before the change and now confirms the original error
propagates without creating a bucket. All 86 storage tests and both Ruff checks
pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
