aglinxinyuan commented on code in PR #8463:
URL: https://github.com/apache/texera/pull/8463#discussion_r4089497349
##########
frontend/src/app/app.module.ts:
##########
@@ -330,15 +328,13 @@ registerLocaleData(en);
CollabWrapperComponent,
AboutComponent,
TexeraLoginComponent,
- UserWorkflowListItemComponent,
SortButtonComponent,
FiltersComponent,
FiltersInstructionsComponent,
SearchComponent,
PortPropertyEditFrameComponent,
WorkflowRuntimeStatisticsComponent,
FlarumComponent,
- HighlightSearchTermsPipe,
SearchBarComponent,
ListItemComponent,
Review Comment:
Applied in 45db957744 — `section-style.scss` loses the `.workflow-list-item`
block with everything nested under it, plus both `.metadata-container` rules
(the one nested in `.section-list-container` at `:123` and the top-level one at
`:213`). The "including css shared by workflow/file item" line in the
`.section-list-container` header goes with them, since `.metadata-container`
was the only item-level rule under it.
`search-results.component.scss:128` held a third `.metadata-container` copy.
It was dead even before this PR, because emulated encapsulation kept it from
reaching the child component's DOM. That copy is out too, so `git grep
metadata-container` now returns nothing. The `search-results.component.html:27`
comment now cites `.list-item-card` in `list-item.component.scss`, the rule
that sets the row height `itemSize="70"` approximates, instead of
`.workflow-list-item`.
I merged `main` in first, since #8005 had added the resource-row rules to
`section-style.scss` in the meantime. `ng build` passes, and the search-results
+ user-workflow specs are green (107 tests).
_🤖 Addressed by [Claude Code](https://claude.com/claude-code)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
