aglinxinyuan opened a new issue, #8660:
URL: https://github.com/apache/texera/issues/8660
### Task Summary
`SearchResultsComponent` declares three inputs it never reads:
`searchKeywords`, `showResourceTypes` and `pid`. Its stylesheet, and the shared
`section-style.scss`, also carry rules that match no element they can reach.
#2793 (2024-08-20, "Generalize List Item") replaced the per-type list items,
and the `nz-layout` / `nz-sider` resource-type icon wrapped around each one,
with the generic `ListItemComponent`. That deleted every template read of the
three inputs, but the inputs and their styles stayed behind.
- **`searchKeywords`** fed each old list item's `[keywords]` input, which
drove the search-term highlight. Both parents, `SearchComponent` and
`HubSearchResultComponent`, still recompute it from the filter bar on every
search and bind it into a component that ignores it.
- **`showResourceTypes`** toggled the per-type icon sider. Both parents
still bind `[showResourceTypes]="true"`.
- **`pid`** was forwarded to the workflow list item. Nothing binds it.
- **`search-results.component.scss`**: `nz-sider`, `nz-content` and
`.resource-type-icon` styled the removed wrapper. `.dataset-search-bar`, the
`.dataset-list-item { … }` block, `.subsection-grid-container` and
`.ant-btn-icon-only` match nothing in the component's own template, which is
the only template an Emulated component stylesheet can reach. The last two also
duplicate the identical rules in `section-style.scss`, which this stylesheet
already `@use`s.
- **`section-style.scss`**: `.section-title .management-panel` and
`.section-title .go-back-button` have not matched anything in a template that
includes the stylesheet since #2776 extracted it. The search page's back button
lives in `SearchComponent`, whose stylesheet does not include it. There is also
a commented-out `.utility-button-group` rule, and a header comment that still
calls the layout "shared between workflows and files section".
`FiltersComponent.getSearchKeywords()` is not part of this: the search
requests themselves still call it.
Dead for about two years. Pure deletion, no behaviour change.
### Task Type
- [x] Refactor / Cleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
