parshimers commented on code in PR #8666:
URL: https://github.com/apache/texera/pull/8666#discussion_r4099546324
##########
bin/mounter/mounter.py:
##########
@@ -237,6 +240,14 @@ def do_mount(cuid, repo, commit, jwt, file_service_base):
"--endpoint", file_service_base,
"--memory-limit", "512",
"-o", "ro,allow_other",
+ ]
+ if CACHE_ROOT:
+ # Keyed by repository and commit, not by computing unit: a commit is
immutable, so
+ # every unit on this node reads one cache rather than each new unit
starting cold.
+ cache_dir = os.path.join(CACHE_ROOT, repo, commit)
+ os.makedirs(cache_dir, exist_ok=True)
Review Comment:
if you specify the path, won't this attempt to make the entire path, not
just the last part?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
