aglinxinyuan opened a new pull request, #8688: URL: https://github.com/apache/texera/pull/8688
### What changes were proposed in this PR? Deletes `BackpressurePause`. It is a `PauseType` that no production code has passed to `PauseManager` since flow control moved onto `ActorMessage`. There is no behaviour change: **+11/−19 lines**. ### History | | | | --- | --- | | **Introduced by** | #1636 (2022-08-20), "Introduce types of pause in Amber". Backpressure paused the worker through `PauseManager` under its own pause type | | **Usage removed by** | #2237 (2023-12-02), "Use ActorMessage for flow control". It deleted the `pauseManager.pause(BackpressurePause)` / `resume(BackpressurePause)` calls | It has been dead for nearly three years. Backpressure still works, but it now bypasses `PauseManager`: `Backpressure(enabled)` arrives as an `ActorCommand` and flips `DPThread.backpressureStatus`. #4533 removed the sibling `SchedulerTimeSlotExpiredPause` for the same reason. > Reviewer note: the specs change in two places, and both are fixture swaps, not lost coverage. > - In `PauseTypeSpec`, the singleton / identity / pattern-match / `Set` cases now cover the remaining three kinds. > - The two `WorkerManagersSpec` `PauseManager` cases used `BackpressurePause` only as "some other pause type". They now use what production actually passes: `OperatorLogicPause` for a global pause (as `DataProcessor` does) and `ECMPause` for a per-channel pause (as ECM alignment does). ### Any related issues, documentation, discussions? Closes #8686 ### How was this PR tested? No new tests. The two existing specs keep their cases with the fixtures swapped. Locally, from the repo root with Java 17: - `sbt "WorkflowExecutionService/Test/compile"`: success. - `sbt "WorkflowExecutionService/testOnly *PauseTypeSpec *WorkerManagersSpec"`: 27 tests, all pass. - `sbt "WorkflowExecutionService/scalafmtCheckAll" "WorkflowExecutionService/scalafixAll --check"`: clean. To re-check: ``` git grep -n BackpressurePause # no hits ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
