aglinxinyuan opened a new issue, #8694:
URL: https://github.com/apache/texera/issues/8694

   ### Task Summary
   
   `ObservableContextManager` in `common/util/context.ts` adds 
enter/exit/change streams on top of `ContextManager`. Nothing has subscribed to 
them since early 2023.
   
   **Introduced by** #1433 (2022-02-07, "Bugfix for Albert load workflow opt"). 
`JointGraphContext` used the change stream to buffer JointJS events while the 
paper was in async mode.
   
   **Usage removed by** #1810 (2023-01-27, "Fix buffering events in JointJS 
async context"). It deleted both `getChangeContextStream()` subscribers and 
handled the buffering another way.
   
   It has been dead for over three and a half years. `JointGraphContext` still 
extends `ObservableContextManager`, so every enter/exit emits on two Subjects 
that no one reads. Only `context.spec.ts` uses the stream API.
   
   This is a pure deletion. `JointGraphContext` would extend `ContextManager` 
directly, with no behaviour change.
   
   ### Task Type
   
   - [x] Refactor / Cleanup
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to