aglinxinyuan opened a new pull request, #8695:
URL: https://github.com/apache/texera/pull/8695
### What changes were proposed in this PR?
Deletes `ObservableContextManager` and re-parents its only subclass,
`JointGraphContext`, onto `ContextManager`. **+8/−223 lines.** There is no
behaviour change: the removed layer only emitted enter/exit events on Subjects
nothing subscribes to, and `JointGraphContext`'s own `enter` / `exit` overrides
still call `super`.
### History
| | |
| --- | --- |
| **Introduced by** | #1433 (2022-02-07), "Bugfix for Albert load workflow
opt". `JointGraphContext` used the change stream to buffer JointJS events in
async mode |
| **Usage removed by** | #1810 (2023-01-27), "Fix buffering events in
JointJS async context". It deleted both `getChangeContextStream()` subscribers |
It has been dead for over three and a half years. Every paper-context
enter/exit since then has emitted into streams with no reader.
> Reviewer note: `context.spec.ts` goes from 23 cases to 12. The 11
stream-only cases are deleted. 4 others move into `describe("ContextManager")`
with their stream assertions dropped, because they cover `ContextManager` paths
the original 8 cases did not: object-identity contexts, nested unwinding when a
callable throws, falsy return values, and re-entering the same value.
### Any related issues, documentation, discussions?
Closes #8694
### How was this PR tested?
No new tests. The kept `ContextManager` cases cover the surviving code.
From `frontend/`:
- `npx ng test --watch=false --include='**/context.spec.ts'
--include='**/joint-graph-wrapper.spec.ts'
--include='**/workflow-editor.component.spec.ts'`: 3 files, 199 tests, all pass.
- `yarn format:ci`: clean.
- `npx ng build`: success.
To re-check:
```
git grep -n
"ObservableContextManager\|getChangeContextStream\|getEnterStream\|getExitStream"
-- frontend # no hits
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
