aglinxinyuan opened a new issue, #8700:
URL: https://github.com/apache/texera/issues/8700
### What happened?
Once a model shows up among the dashboard search bar's suggestions,
autocomplete stops working for the rest of the session. Later keystrokes never
reach the server, and the dropdown stays empty until the page is reloaded.
**Root cause.** The search bar searches every resource kind (`type = null`,
so `resourceType=""`). Since #7930 the backend's all-kinds query unions in
models, and `SearchService.search` keeps rows with a `model` payload.
`SearchBarComponent.convertToName` only names workflows, datasets and files. On
a model row it throws `Unexpected type in SearchResult.`. That throw happens
inside the `switchMap` feeding the search bar's long-lived subscription, and
the subscription has no error handler, so the error ends it for good.
```
Before: type "my" -> results include a model -> convertToName throws ->
subscription errors
type anything else -> nothing happens (subscription is closed)
After: type "my" -> model listed by name
a failed request or unnameable row -> no suggestions for that
query; the next keystroke still searches
```
Any HTTP failure on the search request ends the same subscription the same
way, because both HTTP interceptors rethrow. That includes a 5xx, a dropped
connection, or a 401.
Expected: model hits are listed by name, and one bad response costs only
that query's suggestions.
### How to reproduce?
1. Log in and make sure at least one model you can see matches a keyword,
e.g. a model named `my-model`.
2. Type `my` into the dashboard search bar. No suggestions appear, and the
browser console logs `Error: Unexpected type in SearchResult.`
3. Type a keyword that only matches a workflow. Still no suggestions, and no
new `dashboard/search` request goes out.
### Version/Branch
1.4.0-incubating-SNAPSHOT (main)
### Commit Hash (Optional)
d102e26978cf0a377992b7d3ded03eaccd5d5c75
### What browsers are you seeing the problem on?
_No response_
### Relevant log output
```shell
Error: Unexpected type in SearchResult.
at SearchBarComponent.convertToName (search-bar.component.ts)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
