kz930 opened a new pull request, #8710:
URL: https://github.com/apache/texera/pull/8710

   ### What changes were proposed in this PR?
   
   The two samplers, Split, and If, Dummy and Sleep implement 
`StandaloneCodeGenerator`.
   
   The samplers need more than a pandas expression. A sampler decides per row 
whether to keep it, so which rows survive is fixed by the exact sequence 
`java.util.Random` produces; seeding Python's own generator with the same 
number selects a different set, and the script would then report a different 
sample than the workflow it came from. `SamplingHelpers` transcribes the 
generator, and the three operators that draw from one, the two samplers and 
Split, emit it once per script.
   
   If cannot receive the condition the workflow sets upstream, since that only 
exists at run time. The script takes the True branch as before, and now says so 
on stderr. The message names the variable to set before the step to take the 
False branch.
   
   Review then found two places where the transcribed generator answered a 
question the engine answers differently. It carried its rejection sum as a 
Python integer where Java lets an int overflow, and never refused the bound of 
zero a reservoir of nothing hands it.
   
   The edge values the shared table now carries found one more. The reservoir 
sampler rebuilt its output from the rows' values, so pandas inferred each 
column again and a timestamp past 2262 came back as an object column. It now 
takes the rows from the input by position.
   
   ### Any related issues, documentation, discussions?
   
   Part of #8325, step 11c; that issue lists the set in order.
   
   Closes #8708, the task this change is the whole of.
   
   ### How was this PR tested?
   
   Each operator asserts the block it emits in its own spec. What the verify 
tables cannot reach stays here as executed tests: the samplers' draws against 
`java.util.Random`, a reservoir of nothing, and the warning If prints when 
nothing sets its condition.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Claude Opus 5)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to