Copilot commented on code in PR #8713:
URL: https://github.com/apache/texera/pull/8713#discussion_r4114323103
##########
common/config/src/main/resources/storage.conf:
##########
@@ -152,10 +152,11 @@ storage {
interval-minutes = ${?STORAGE_CLEANUP_INTERVAL_MINUTES}
}
- # Per-user warehouse feature (#6870). One switch that hides the whole
feature until it
- # is fully built: merging the warehouse PRs changes nothing while this
stays off.
+ # Per-user warehouse feature (#6870). Only takes effect with the REST
catalog
+ # (Lakekeeper), since warehouses are Lakekeeper entities; any other
catalog type
+ # keeps the feature off whatever this says.
warehouse {
- enabled = false
+ enabled = true
Review Comment:
This changes the default to enabled, but `StorageConfigSpec` still asserts
`warehouseEnabled shouldBe false` whenever `STORAGE_WAREHOUSE_ENABLED` is
unset. Because this file also defaults the catalog to `rest`, running
`Config/test` without CI's `postgres` override now deterministically fails.
Update that spec to assert the new REST default and retain coverage that
non-REST catalogs force the feature off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
