aglinxinyuan opened a new pull request, #8715:
URL: https://github.com/apache/texera/pull/8715

   ### What changes were proposed in this PR?
   
   Deletes `bin/pylsp/python-language-server.yaml`, a standalone Kubernetes 
Deployment + Service for the Python language server that nothing applies. It 
pulled a personal image (`jxzliu/pylsp:latest`) with a `regcred` pull secret 
into a hard-coded `texera` namespace. **−61 lines.** There is no behaviour 
change: the Helm chart's own pylsp template 
(`bin/k8s/templates/base/pylsp/pylsp.yaml`, image `texera/pylsp`) is what 
actually deploys the server. `bin/pylsp/Dockerfile` and `run_pylsp.sh`, which 
build that image, stay.
   
   ### History
   
   | | |
   | --- | --- |
   | **Introduced by** | #3441 (2025-05-19), "Add `share-editing-server` and 
`pylsp` dockerfiles to the deployment folder". It was moved unchanged by #3883 
and #3892 |
   | **Usage removed by** | **never used**. No script, CI job, doc or 
Dockerfile applies or copies it. The Helm pylsp template from #3337 
(2025-04-05) predates it and has been the real deployment all along |
   
   It has duplicated the Helm template since the day it was added, about 
sixteen months ago. Its Service name (`python-language-server-service`) doesn't 
even match the one the gateway routes to (`python-language-server-svc`).
   
   ### Any related issues, documentation, discussions?
   
   Closes #8714
   
   ### How was this PR tested?
   
   No new tests; this deletes a deployment file that nothing reads.
   
   - `bash bin/k8s/tests/test_helm_values.sh`: PASS (156 template value 
references checked across 53 files).
   - `git grep -n "python-language-server"`: the remaining hits are the Helm 
pylsp values, the gateway route, and the language-server path and port settings 
(`gui.conf`, the code editor, `pyright-language-service`). None of them 
reference the deleted file.
   - `bin/build-images.sh` builds `pylsp/Dockerfile` with context `./pylsp`, 
and the Dockerfile copies only `run_pylsp.sh`, so the image never contained the 
manifest.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Claude Opus 5.5)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to