aglinxinyuan opened a new pull request, #8742: URL: https://github.com/apache/texera/pull/8742
### What changes were proposed in this PR? Removes the UDF Python log settings that nothing reads. **−30 lines.** There is no behaviour change. - `udf.conf`: the `python.log.fileHandler` section (`dir`, `level`, `format` and their `UDF_PYTHON_LOG_FILEHANDLER_*` overrides) and `python.log.streamHandler.format` (with `UDF_PYTHON_LOG_STREAMHANDLER_FORMAT`). - `UdfConfig`: `pythonLogStreamHandlerFormat`, `pythonLogFileHandlerDir`, `pythonLogFileHandlerLevel`, `pythonLogFileHandlerFormat`. The vals and the keys go together, because the vals' eager `getString` would throw once a key is gone. - `UdfConfigSpec`: the assertions for the removed settings. `python.log.streamHandler.level` stays. `PythonWorkflowWorker` forwards it as `loggerLevel`, and CI sets `UDF_PYTHON_LOG_STREAMHANDLER_LEVEL`. ### History | | | | --- | --- | | **Introduced by** | #1119 (2021-05-13), "Add simple debug logging to PythonUDF": the conf keys. #3466 (2025-06-12), "Move all conf files and readers to `core/config`": the `UdfConfig` vals | | **Usage removed by** | #1958 (2023-06-04), "Remove the deprecated Python UDF V1". It deleted the Java launcher that read these keys and attached the file handler. The `UdfConfig` vals were **never used** | The keys have been dead for over three years. The worker installs one stderr sink at the forwarded level and has never received a format or a file-handler setting since #1958. ### Any related issues, documentation, discussions? Closes #8741 ### How was this PR tested? No new tests. `UdfConfigSpec` keeps its cases for the surviving settings. Locally, from the repo root with Java 17: - `sbt "Config/Test/compile" "WorkflowExecutionService/Test/compile"`: success. - `sbt "Config/testOnly *UdfConfigSpec *PythonUtilsSpec"`: 4 tests, all pass. - `sbt "Config/scalafmtCheckAll" "Config/scalafixAll --check" "WorkflowExecutionService/scalafmtCheckAll" "WorkflowExecutionService/scalafixAll --check"`: clean. To re-check: ``` git grep -n -E "fileHandler|LOG_FILEHANDLER|STREAMHANDLER_FORMAT|pythonLogStreamHandlerFormat" # no hits ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
