aglinxinyuan commented on code in PR #8639:
URL: https://github.com/apache/texera/pull/8639#discussion_r4140047126
##########
amber/src/test/integration/org/apache/texera/amber/engine/e2e/LoopIntegrationSpec.scala:
##########
@@ -317,6 +329,26 @@ class LoopIntegrationSpec
)
}
+ it should "bind a $i loop-variable reference in a JVM operator's property on
every iteration" in {
Review Comment:
c823b4b9b7 adds three runs, built like the existing cases:
- a number setting: `TextInput(3 rows) -> Loop Start (n = 1) -> Limit($n) ->
Loop End (n <= len(table))`, which gives 1 + 2 + 3 = 6 rows at Loop End;
- nested loops that both name `i`, with `Filter(line = $i)` in the inner
body: all 2 × 2 rows pass only with the inner `i`;
- two branches, Limit and Sleep, meeting at a Union before `Filter(line =
$i)`: 2 copies × 3 iterations = 6.
The cases from my other comments are unit tests. The outside-input compile
errors are in `WorkflowCompilerSpec`: both Interval Join cases, an input with
links from inside and outside, and the nested and sibling-block cases. The
typed `"$n"` through each Dropwizard mapper is in `ComputingUnitMasterSpec` and
`WorkflowCompilingServiceRunSpec`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
