aglinxinyuan opened a new pull request, #8819: URL: https://github.com/apache/texera/pull/8819
### What changes were proposed in this PR? Removes three exported types from `execute-workflow.interface.ts` that nothing imports: `InputPort`, `OutputPort` and `WebOutputMode`. **−9 lines.** There is no behaviour change: they are compile-time types with no reference anywhere in the repo, so they never reach the built JavaScript. `WebPaginationUpdate.mode` and `WebDataUpdate.mode` still name their mode types directly, as before. ### History | | | | --- | --- | | **Introduced by** | #1214 (2021-07-05), "Refactor frontend to handle different incremental output mode": `WebOutputMode`. #2299 (2024-01-20), "Refactor backend ports in compiler": `InputPort`, `OutputPort` | | **Usage removed by** | #7783 (2026-08-22). It deleted `OperatorAvailableResult`, whose `outputMode` field was the only use of `WebOutputMode`, and left the alias behind. `InputPort` / `OutputPort` were **never used** | The port types have been unused for the twenty months since they were added. ### Any related issues, documentation, discussions? Closes #8818 ### How was this PR tested? No new tests; these are type-only deletions. From `frontend/`: - `npx ng test --watch=false`, with one `--include` for the file's own spec plus each of the 21 specs that import it (22 files): 1412 tests pass, 1 is skipped (an existing `it.skip` elsewhere). - `npx tsc --noEmit -p src/tsconfig.app.json`: clean. - `yarn format:ci`: clean. - `npx ng build`: success. To re-check: ``` git grep -n -w -E "InputPort|OutputPort|WebOutputMode" -- frontend ':!frontend/src/app/common/type/proto' # no hits (the generated proto module has its own, unrelated InputPort/OutputPort) ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
