mengw15 commented on code in PR #8806: URL: https://github.com/apache/texera/pull/8806#discussion_r4172140369
########## common/workflow-core/src/main/protobuf/scalapb/scalapb.proto: ########## @@ -1,19 +1,6 @@ -// Licensed to the Apache Software Foundation (ASF) under one -// or more contributor license agreements. See the NOTICE file -// distributed with this work for additional information -// regarding copyright ownership. The ASF licenses this file -// to you under the Apache License, Version 2.0 (the -// "License"); you may not use this file except in compliance -// with the License. You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, -// software distributed under the License is distributed on an -// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -// KIND, either express or implied. See the License for the -// specific language governing permissions and limitations -// under the License. +// This file is vendored from ScalaPB and is licensed under the Review Comment: You're right — re-checked against every tag: `diff -w` is zero at v0.11.4, and `go_package` never existed there (the differences I attributed to local edits were later upstream additions). Notice now says v0.11.4 with your wording, in 9084fc28a. Bumping the vendored file to match the pinned 0.11.20 compilerplugin sounds like a reasonable separate follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
