aglinxinyuan opened a new pull request, #8837: URL: https://github.com/apache/texera/pull/8837
### What changes were proposed in this PR? Removes the leftovers of the execution-snapshot column from the workflow execution-history modal. **−14 lines.** There is no behaviour change. - **Styles:** the `.version-sample` and `.workflow-snapshot` rules in `workflow-execution-history.component.scss`. Nothing uses either class: the template has no static or dynamic use, the component uses emulated encapsulation, and no other stylesheet or `::ng-deep` relies on them. - **Column width:** the `"Workflow Version Sample"` entry in `customColumnWidth`. `executionsTableHeaders` no longer lists that column, so the template's `customColumnWidth[column]` lookup never reads the key. ### History | | | | --- | --- | | **Introduced by** | #1634 (2022-10-04), "Introduce execution snapshot". It added a "Workflow Version Sample" column showing a snapshot per execution, styled by these classes and sized by this width entry | | **Usage removed by** | #1695 (2022-10-18), "Remove snapshot feature and fix version pagination". It deleted the column header and the markup that used both classes, but kept the rules and the width entry | They have been dead for nearly four years. ### Any related issues, documentation, discussions? Closes #8836 ### How was this PR tested? No new tests; no spec referenced any of them. From `frontend/`: - `npx ng test --watch=false --include='**/workflow-execution-history.component.spec.ts' --include='**/admin-execution.component.spec.ts' --include='**/left-panel.component.spec.ts'`: 3 files, 138 tests, all pass. The last two specs cover the components that host this modal. - `yarn format:ci`: clean. - `npx ng build`: success. To re-check: ``` git grep -n -E "version-sample|workflow-snapshot|Version Sample" -- frontend # no hits ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
